Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3/4 Make RandomAccessReader.isMotorolaByteOrder read only #585

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

don-vip
Copy link

@don-vip don-vip commented Jun 18, 2022

This is the third step towards solving #278

Port of this commit:

  1. drewnoakes/metadata-extractor-dotnet@2338a37

The PR is built on top of #584

@don-vip don-vip changed the title Make IndexedReader.IsMotorolaByteOrder read only Make RandomAccessReader.isMotorolaByteOrder read only Jun 18, 2022
@don-vip don-vip changed the title Make RandomAccessReader.isMotorolaByteOrder read only 3/4 Make RandomAccessReader.isMotorolaByteOrder read only Jun 19, 2022
@don-vip don-vip force-pushed the tiff-byte-order branch 4 times, most recently from cdbad8d to c4a09a6 Compare June 19, 2022 23:04
don-vip and others added 7 commits July 20, 2024 16:37
… than passing TIFF header offsets around everywhere.
Note that while BigTIFF supports files greater than 2 GiB in size, our current implementation does not due to the pervasive use of Int32 throughout the code to represent offsets into the data.
This will only ever be a 16-bit value.
This allows combining the add and test operations into a single lookup.
If the byte order changes during extraction, a new reader is made via WithByteOrder.
That new reader is naturally scoped to the sub-reading operation, and the byte order
does not need to be reverted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants